Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data-plane]: bump protobuf.version from 3.25.2 to 4.26.1 in /data-plane #3897

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 14, 2024

Bumps protobuf.version from 3.25.2 to 4.26.1.
Updates com.google.protobuf:protobuf-java from 3.25.2 to 4.26.1

Commits

Updates com.google.protobuf:protobuf-java-util from 3.25.2 to 4.26.1

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps `protobuf.version` from 3.25.2 to 4.26.1.

Updates `com.google.protobuf:protobuf-java` from 3.25.2 to 4.26.1
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

Updates `com.google.protobuf:protobuf-java-util` from 3.25.2 to 4.26.1

---
updated-dependencies:
- dependency-name: com.google.protobuf:protobuf-java
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: com.google.protobuf:protobuf-java-util
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels May 14, 2024
@knative-prow knative-prow bot requested review from Cali0707 and pierDipi May 14, 2024 21:38
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/data-plane labels May 14, 2024
Signed-off-by: Knative Automation <automation@knative.team>
Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from pierdipi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented May 14, 2024

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_main 252e974 link true /test unit-tests
integration-tests_eventing-kafka-broker_main 252e974 link true /test integration-tests
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main 252e974 link true /test channel-reconciler-tests-sasl-plain
reconciler-tests_eventing-kafka-broker_main 252e974 link true /test reconciler-tests
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main 252e974 link true /test channel-reconciler-tests-sasl-ssl
channel-integration-tests-sasl-plain_eventing-kafka-broker_main 252e974 link true /test channel-integration-tests-sasl-plain
channel-integration-tests-sasl-ssl_eventing-kafka-broker_main 252e974 link true /test channel-integration-tests-sasl-ssl
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 252e974 link true /test reconciler-tests-namespaced-broker
upgrade-tests_eventing-kafka-broker_main 252e974 link true /test upgrade-tests
reconciler-tests-keda_eventing-kafka-broker_main 252e974 link true /test reconciler-tests-keda
channel-reconciler-tests-ssl_eventing-kafka-broker_main 252e974 link true /test channel-reconciler-tests-ssl
channel-integration-tests-ssl_eventing-kafka-broker_main 252e974 link true /test channel-integration-tests-ssl

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Cali0707
Copy link
Member

@pierDipi it looks like this update breaks the generated contract code (at least on the Java side)

Should we open an issue to capture updating this ourselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-plane dependencies Pull requests that update a dependency file java Pull requests that update Java code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants