Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PodDisruptionBudget v1 #1278

Conversation

aliok
Copy link
Member

@aliok aliok commented Dec 26, 2022

Fixes #

Proposed Changes

  • Use PodDisruptionBudget v1

Release Note


Docs

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 26, 2022
@aliok
Copy link
Member Author

aliok commented Dec 26, 2022

/cherrypick release-1.8

@knative-prow-robot
Copy link
Contributor

@aliok: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1278 (2592122) into main (20e1b33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1278   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         128      128           
  Lines        9017     9017           
=======================================
  Hits         6757     6757           
  Misses       2029     2029           
  Partials      231      231           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aliok
Copy link
Member Author

aliok commented Dec 26, 2022

/test upgrade-tests

@knative-prow
Copy link

knative-prow bot commented Dec 26, 2022

@aliok: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka_main 2592122 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aliok
Copy link
Member Author

aliok commented Dec 26, 2022

During upgrade tests, installing the previous version fails because of inexistent PodDisruptionBudget in policy/v1beta1.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/apporve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented Jan 3, 2023

During upgrade tests, installing the previous version fails because of inexistent PodDisruptionBudget in policy/v1beta1.

I'd assume that the CI for the previous job is also on the same k8s version as this one? If so, hard to address.
Unless we go all the way back (assuming older versions of our software run on older k8s versions where this actually fits).

That said, but I am not sure really worth it, see: #1259

@aliok
Copy link
Member Author

aliok commented Jan 5, 2023

@knative-prow knative-prow bot closed this Jan 5, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 5, 2023

@aliok: Closed this PR.

In response to this:

/close

Context: https://knative.slack.com/archives/C02C56QF282/p1672925909239859

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants