-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PodDisruptionBudget v1 #1278
Use PodDisruptionBudget v1 #1278
Conversation
/cherrypick release-1.8 |
@aliok: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #1278 +/- ##
=======================================
Coverage 74.93% 74.93%
=======================================
Files 128 128
Lines 9017 9017
=======================================
Hits 6757 6757
Misses 2029 2029
Partials 231 231 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test upgrade-tests |
@aliok: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
During upgrade tests, installing the previous version fails because of inexistent PodDisruptionBudget in policy/v1beta1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/apporve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd assume that the CI for the previous job is also on the same k8s version as this one? If so, hard to address. That said, but I am not sure really worth it, see: #1259 |
/close Context: https://knative.slack.com/archives/C02C56QF282/p1672925909239859 |
@aliok: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #
Proposed Changes
Release Note
Docs