Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate components #1259

Closed
wants to merge 1 commit into from
Closed

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Oct 18, 2022

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Proposed Changes

  • Adding note that some components in repo are no longer maintained.

Release Note


Docs

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1259 (1990f18) into main (07af4e8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         128      128           
  Lines        9017     9017           
=======================================
  Hits         6757     6757           
  Misses       2029     2029           
  Partials      231      231           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pierDipi
Copy link
Member

@pierDipi
Copy link
Member

pierDipi commented Nov 7, 2022

@dprotaso
Copy link
Contributor

dprotaso commented Nov 7, 2022

If the components are specific to certain packages you can probably mark those packages are deprecated using godoc

https://go.dev/blog/godoc

@creydr
Copy link
Contributor

creydr commented Jan 23, 2023

Can we remove them from the released YAMLs:

https://github.com/knative-sandbox/eventing-kafka/blob/07af4e8e1ee3e5469b94073bc497b2619c310650/hack/release.sh#L26-L34

Should we continue on this? We have some CI upgrade test failures, as it uses some deprecated API version for PodDisruptionBudget and HPA (see #1287 for example). Or would we first have to deprecate but keep them in the yamls for a few releases?

@pierDipi
Copy link
Member

@creydr yes, please, we cannot move forward with the release (yesterday) without this

@pierDipi
Copy link
Member

See #1327

@pierDipi pierDipi closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants