Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated components #1327

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Apr 12, 2023

The deprecated consolidated and distributed KafkaChannel implementations have been removed.
Automatic migration from the consolidated KafkaChannel is provided as part of the eventing-kafka-broker implementation.

The deprecated single tenant KafkaSource implementations has been removed.
Automatic migration from the single tenant KafkaSource implementation is provided as part of the eventing-kafka-broker implementation.

Proposed Changes

  • Remove channels and st source

Release Note

The deprecated consolidated and distributed `KafkaChannel` implementations have been removed.
Automatic migration from the consolidated `KafkaChannel` is provided as part of the eventing-kafka-broker implementation.

The deprecated single tenant KafkaSource implementations has been removed.
Automatic migration from the single tenant KafkaSource implementation is provided as part of the eventing-kafka-broker implementation.

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1327 (7a122e5) into main (32592eb) will decrease coverage by 6.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
- Coverage   74.93%   68.21%   -6.73%     
==========================================
  Files         128       39      -89     
  Lines        9017     2369    -6648     
==========================================
- Hits         6757     1616    -5141     
+ Misses       2029      673    -1356     
+ Partials      231       80     -151     

see 20 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@pierDipi pierDipi changed the title [WIP] Remove deprecated components Remove deprecated components Apr 12, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2023
@pierDipi
Copy link
Member Author

/cc @matzew @aliok @creydr

@knative-prow knative-prow bot requested review from aliok, creydr and matzew April 12, 2023 10:41
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-test-channel-consolidated_eventing-kafka_main 7a122e5 link true /test integration-test-channel-consolidated
integration-test-channel-consolidated-sasl_eventing-kafka_main 7a122e5 link true /test integration-test-channel-consolidated-sasl
integration-test-channel-distributed_eventing-kafka_main 7a122e5 link true /test integration-test-channel-distributed

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member Author

Removed the unnecessary jobs in knative/test-infra#3795

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f60c92c into knative-extensions:main Apr 12, 2023
@pierDipi pierDipi deleted the remove-deprecated-components branch April 12, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants