Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Receive Adapter and Dispatcher BackoffDelay period parsing #750

Merged

Conversation

gabo1208
Copy link
Contributor

@gabo1208 gabo1208 commented May 9, 2022

Changes

  • 🐛 Now the backoffDelay env variable is parsed correctly on the Broker's and Trigger's Dispatcher
  • 🐛 Now the backoffDelay env variable is parsed correctly on the Source's receive adapter
  • 🧹 Added condition to Broker's e2e tests to try to catch this kind of bugs earlier

/kind bug

Fixes #748

Release Note

- :bug: Now the backoffDelay env variable is parsed correctly on the Broker's and Trigger's Dispatcher
- :bug: Now the backoffDelay env variable is parsed correctly on the Source's receive adapter

…and the dispatcher + added e2e test condition to try to catch this errors sooner in the broker side
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2022
@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #750 (77647ab) into main (db03f78) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   74.79%   74.82%   +0.02%     
==========================================
  Files          35       35              
  Lines        2575     2578       +3     
==========================================
+ Hits         1926     1929       +3     
  Misses        582      582              
  Partials       67       67              
Impacted Files Coverage Δ
pkg/reconciler/broker/resources/dispatcher.go 89.79% <100.00%> (+0.10%) ⬆️
pkg/reconciler/source/resources/receive_adapter.go 96.10% <100.00%> (+0.02%) ⬆️
pkg/reconciler/trigger/resources/dispatcher.go 91.59% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db03f78...77647ab. Read the comment docs.

Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@knative-prow
Copy link

knative-prow bot commented May 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 291010d into knative-extensions:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broker Delivery Backoff policy is not being correctly parsed in the Dispatcher and the Receive adapter
2 participants