Broker ingress and Dispatcher now uses the protocol binding instead of json to process events #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
kind/enhancement
kind/performance
size/XXL
Codecov Report
@@ Coverage Diff @@
## main #751 +/- ##
==========================================
- Coverage 75.20% 74.84% -0.37%
==========================================
Files 36 35 -1
Lines 2654 2544 -110
==========================================
- Hits 1996 1904 -92
+ Misses 588 576 -12
+ Partials 70 64 -6
Continue to review full report at Codecov.
|
gabo1208
force-pushed
the
protocol-spec-for-broker-and-source
branch
3 times, most recently
from
b27ea9c
to
c8a46a9
Compare
knative-prow-robot
added
the
needs-rebase
…ces + recreated perf test images
…hmarks images + readme
…ntry point for the source in the conformance tests, the changes to the broker to support this are going to be made in another commit + created source perf test results and published images, the performance gains while using the binary protocol binding vs json manipulation seems to be significant memorywise
using ce protocol binding to get msg from a rabbitmq msg delivery
… does not support header on its test channels excluding adapter from the golangci-lint while wabbit is been removed from the repo added missing ce attributes to msg headers in ingres added source to message header so it will be filtered appropriately added support for timestamp in the ingress formating trying different approach with cloudevents and filters
gabo1208
force-pushed
the
protocol-spec-for-broker-and-source
branch
from
adb2b61
to
779cd76
Compare
knative-prow-robot
removed
the
needs-rebase
fixed broker perf test setup + removed unused file + rebased
removed ununsed header using the contentype header avoid using rabbitmq specific headers when translating rabbitmq messages to cloudevents + small refactor on the dispatcher
… rabbitmq message + fixed malformed json in e2e test producer fixing e2e and conformance tests to match expected output removed unnecesary cast
gabo1208
force-pushed
the
protocol-spec-for-broker-and-source
branch
from
2a82180
to
c839f5a
Compare
gab-satchi
reviewed
May 12, 2022
…stead of the one defined by the test
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gab-satchi, gabo1208 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #750
Changes
/kind enhancement performance
Fixes #
Release Note