Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance results automation #767

Merged

Conversation

gabo1208
Copy link
Contributor

Changes

  • 🎁 Script to automate the generation of the performance results per release
  • 🎁 Complete performance results graph tests for the RabbitMQ's Broker and Source

/kind enhancement

Fixes #749

Release Note

- 🎁 Script to automate the generation of the performance results per release
- 🎁 Complete performance results graph tests for the RabbitMQ's Broker and Source

@knative-prow knative-prow bot added kind/enhancement size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2022
@gabo1208
Copy link
Contributor Author

/hold
Please merge after #751

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #767 (f51a0ab) into main (a2b8790) will not change coverage.
The diff coverage is n/a.

❗ Current head f51a0ab differs from pull request most recent head 7daeb24. Consider uploading reports for the commit 7daeb24 to get more accurate results

@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   75.33%   75.33%           
=======================================
  Files          35       35           
  Lines        2526     2526           
=======================================
  Hits         1903     1903           
  Misses        559      559           
  Partials       64       64           
Impacted Files Coverage Δ
pkg/rabbit/message.go 68.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b8790...7daeb24. Read the comment docs.

@gabo1208 gabo1208 force-pushed the performance-results-automation branch from bb1c624 to bf2a646 Compare May 16, 2022 15:22
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 16, 2022
@gabo1208 gabo1208 closed this May 16, 2022
@gabo1208 gabo1208 reopened this May 16, 2022
@gabo1208
Copy link
Contributor Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2022
@gabo1208 gabo1208 force-pushed the performance-results-automation branch from 4b24ac9 to 7a73d26 Compare May 16, 2022 17:42
…ntry point for the source in the conformance tests, the changes to the broker to support this are going to be made in another commit + created source perf test results and published images, the performance gains while using the binary protocol binding vs json manipulation seems to be significant memorywise
using ce protocol binding to get msg from a rabbitmq msg delivery
… does not support header on its test channels

excluding adapter from the golangci-lint while wabbit is been removed from the repo

added missing ce attributes to msg headers in ingres

added source to message header so it will be filtered appropriately

added support for timestamp in the ingress formating

trying different approach with cloudevents and filters
fixed broker perf test setup + removed unused file + rebased

fixed adapter's unit tests

removed ununsed header

using the contentype header

avoid using rabbitmq specific headers when translating rabbitmq messages to cloudevents + small refactor on the dispatcher
… rabbitmq message + fixed malformed json in e2e test producer

fixing e2e and conformance tests to match expected output

removed unnecesary cast
….4 results with it + tinker with some yamls and readme to reflect changes and make some of the parameters configurable by env variables
@gabo1208 gabo1208 force-pushed the performance-results-automation branch from 7a73d26 to dd902b4 Compare May 17, 2022 15:38
fixing rabbitmq's cluster operator version

fixing lint and typo

fixing license boilerplate in the sh

updated codegen with new boilerplate format
@gabo1208 gabo1208 force-pushed the performance-results-automation branch from f51a0ab to 7daeb24 Compare May 17, 2022 16:54
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2022
@knative-prow
Copy link

knative-prow bot commented May 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit dff945a into knative-extensions:main May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Performance Results generation
2 participants