Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly releases are failing #100

Closed
dsimansk opened this issue Nov 9, 2021 · 1 comment · Fixed by #101
Closed

Nightly releases are failing #100

dsimansk opened this issue Nov 9, 2021 · 1 comment · Fixed by #101
Assignees
@cardil

Comments

@dsimansk
Copy link
Contributor

dsimansk commented Nov 9, 2021

That might be related to v1.0.0 release

[MAGE] ✅ Testing was successful.
[MAGE] 🔨 Building
[MAGE] 🔨 › 💿 kn-event-sender
fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
Error: unexpected error: running "git ls-remote --tags origin" failed with exit code 128
exit status 1
+ EXIT_VALUE=1
+ set +o xtrace

See the log:
https://prow.knative.dev/view/gs/knative-prow/logs/ci-knative-sandbox-kn-plugin-event-nightly-release/1457996516202385408#1:build-log.txt%3A1186
@cardil
Copy link
Contributor

cardil commented Nov 9, 2021 •
edited
Loading

Thanks for raising this @dsimansk!

I rather think this is connected to merge of #87. For whatever reason, the origin isn't set on prow nightly job. And after #87 it is used to list remote tags, so we can filter what tags should apply to given image.

Luckily, we could easily set that. PR comming...

/assign

@cardil cardil mentioned this issue Nov 9, 2021
Merged
cardil added a commit to cardil/kn-plugin-event that referenced this issue Mar 4, 2022
@cardil
[1.0] Running e2e tests on OpenShift (knative-extensions#100)
75d186b 
* Allow to override the test image resolver, to use env variables. (knative-sandbox#168)

Also, fixing test of `test/pkg/k8s.TestResolveAddress` which behaved
flaky on downstream projects.

* Overrides to run e2e tests on OpenShift (knative-extensions#99)

* Overrides to run e2e tests on OpenShift
* Use artifacts from ocp/tools image
* Running GolangCI Lint only if there is a golangci config file
cardil added a commit to cardil/kn-plugin-event that referenced this issue Mar 31, 2022
@cardil
[1.1] Backport of knative-extensions#100
886dc2b 
- knative-extensions#168
- openshift-knative#99
cardil added a commit to cardil/kn-plugin-event that referenced this issue Mar 31, 2022
@cardil
[1.1] Backport of knative-extensions#100
dfde7a6 
- knative-extensions#168
- openshift-knative#99
cardil added a commit to cardil/kn-plugin-event that referenced this issue Mar 31, 2022
@cardil
[1.2] Backport of knative-extensions#129
4811b3d 
 * [1.1] Backport of knative-extensions#85

   - knative-sandbox#126
   - Parts of knative-extensions/reconciler-test#284
   - knative-sandbox#146
   - knative-sandbox#159

 * [1.1] Backport of knative-extensions#100

   - knative-extensions#168
   - openshift-knative#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cardil cardil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Configure git remote in case the source isn't checkout from origin cardil/kn-plugin-event
2 participants
@cardil @dsimansk