Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Release version and compatibility tags resoved properly at CI #87

Merged

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Oct 29, 2021

Changes

  • 馃悰 Release version is resolved properly at CI
  • 馃悰 OCI image compatibility tags are resolved for a given release using git information

/kind bug

Fixes #77

Showcase

asciicast

@knative-prow-robot knative-prow-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 29, 2021
@knative-prow-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 29, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #87 (0ad3337) into main (529949c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   69.83%   69.83%           
=======================================
  Files          29       29           
  Lines         799      799           
=======================================
  Hits          558      558           
  Misses        184      184           
  Partials       57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 529949c...0ad3337. Read the comment docs.

@cardil cardil marked this pull request as ready for review October 29, 2021 15:53
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2021
@cardil
Copy link
Contributor Author

cardil commented Oct 29, 2021

/cc @rhuss
/cc @dsimansk
/cc @jrangelramos

@dsimansk
Copy link
Contributor

Thanks!

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7e20940 into knative-extensions:main Oct 29, 2021
@cardil cardil deleted the bugfix/release-tags branch October 29, 2021 18:10
@cardil
Copy link
Contributor Author

cardil commented Oct 29, 2021

/cherrypick release-0.26

@knative-prow-robot
Copy link

@cardil: #87 failed to apply on top of branch "release-0.26":

Applying: Switching to Knative-style version resolver
.git/rebase-apply/patch:287: new blank line at EOF.
+
.git/rebase-apply/patch:357: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
M	vendor/golang.org/x/net/http2/transport.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/golang.org/x/net/http2/transport.go
Removing vendor/github.com/wavesoftware/go-magetasks/pkg/git/version.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Switching to Knative-style version resolver
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cardil added a commit to cardil/kn-plugin-event that referenced this pull request Oct 29, 2021
knative-prow-robot pushed a commit that referenced this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto released binaries and images are not tagged with proper release
3 participants