Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.26] 馃悰 Back port of #87 #90

Merged

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Oct 29, 2021

Changes

/kind bug

Follow up on #77

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 29, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 29, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 29, 2021
@cardil
Copy link
Contributor Author

cardil commented Oct 29, 2021

/cc @rhuss
/cc @dsimansk
/cc @vyasgun

@cardil cardil changed the title Back port of #87 馃悰 Back port of #87 for 0.26 release Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #90 (944c55e) into release-0.26 (7f0b0fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           release-0.26      #90   +/-   ##
=============================================
  Coverage         69.83%   69.83%           
=============================================
  Files                29       29           
  Lines               799      799           
=============================================
  Hits                558      558           
  Misses              184      184           
  Partials             57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7f0b0fd...944c55e. Read the comment docs.

@dprotaso dprotaso changed the title 馃悰 Back port of #87 for 0.26 release [release-0.26] 馃悰 Back port of #87 Oct 29, 2021
@dprotaso
Copy link

/lgtm
/approve

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@knative-prow-robot knative-prow-robot merged commit 5b0b669 into knative-extensions:release-0.26 Oct 29, 2021
@cardil cardil deleted the backport/0.26/87 branch October 29, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants