-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make ingressSync run in parallel #879
make ingressSync run in parallel #879
Conversation
@junydania: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Welcome @junydania! It looks like this is your first PR to knative-sandbox/net-kourier 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: junydania The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @junydania. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thank you so much @junydania Did this PR solve #840 ? |
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 80.77% 80.77%
=======================================
Files 18 18
Lines 1233 1233
=======================================
Hits 996 996
Misses 190 190
Partials 47 47 Continue to review full report at Codecov.
|
This Pull Request is stale because it has been open for 90 days with |
This issue or pull request is stale because it has been open for 90 days with no activity. This bot triages issues and PRs according to the following rules:
You can:
/lifecycle stale |
This Pull Request is stale because it has been open for 90 days with |
Changes
Executes the ingressSync in parallel. Suggesting this change due to a problem we encountered with net-kourier priming ingresses.
With over 1,500 services in a cluster, it takes over 20-30mins for this to complete.
Though we can run this process in parallel