Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default gRPC readiness probe #981

Merged
merged 1 commit into from
May 1, 2023
Merged

Use default gRPC readiness probe #981

merged 1 commit into from
May 1, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jan 25, 2023 •
edited
Loading

As per title, this patch changes to use default gRPC readiness probe.

Additional Note
Current timeout is 100 milli seconds but timeoutSeconds is minimum 1 second so this change will make the timeout longer than current.

$ kubectl explain pod.spec.containers.readinessProbe.timeoutSeconds
KIND:     Pod
VERSION:  v1

FIELD:    timeoutSeconds <integer>

DESCRIPTION:
     Number of seconds after which the probe times out. Defaults to 1 second.
     Minimum value is 1. More info:
     https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle#container-probes

Fix #923

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #981 (4a09a6a) into main (28aa7dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          18       18           
  Lines        1343     1343           
=======================================
  Hits         1085     1085           
  Misses        205      205           
  Partials       53       53

@nak3
Copy link
Contributor Author

nak3 commented Jan 25, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2023
@nak3 nak3 changed the title Use default gRPC readiness probe [WIP] Use default gRPC readiness probe Jan 25, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2023
@skonto
Copy link
Contributor

skonto commented Mar 28, 2023

@nak3 is this ready?

@nak3 nak3 changed the title [WIP] Use default gRPC readiness probe Use default gRPC readiness probe Apr 3, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2023
@nak3 nak3 changed the title Use default gRPC readiness probe [WIP] Use default gRPC readiness probe Apr 3, 2023
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2023
@nak3
Copy link
Contributor Author

nak3 commented Apr 3, 2023

This will be a breaking change for the old k8s cluster (or OCP) so we will not merge until we are sure that the gRPC readiness probe is available. (after 1.10 or 1.11 release.)
But please feel free to ping here if somebody wants to get this PR merge. Downstream can make a patch if necessary.

@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 26, 2023
@nak3 nak3 changed the title [WIP] Use default gRPC readiness probe Use default gRPC readiness probe Apr 27, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2023
@nak3
Copy link
Contributor Author

nak3 commented Apr 27, 2023

/hold cancel
/cc @skonto @ReToCode

This is now ready.

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2023
ReToCode
ReToCode approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it.

/lgtm
/hold for other reviewers to chime in.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 1, 2023
@knative-prow knative-prow bot merged commit 23f527a into knative-extensions:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@skonto skonto Awaiting requested review from skonto

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use k8s's default gRPC readinessProbe
4 participants
@nak3 @skonto @ReToCode @knative-prow-robot