Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go_run instead of run_go_tool #825

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Use go_run instead of run_go_tool #825

merged 2 commits into from
Jan 9, 2024

Conversation

chmouel
Copy link
Contributor

@chmouel chmouel commented Dec 4, 2023 •
edited

Changes

🧹 As per the error message whhen running update-codegen.sh

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!! WARN: The "run_go_tool" function is deprecated. Use "go_run" instead. !!!! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

run_go_tool function has been deprecated in favour of go_run

/kind misc

Fixes #

Release Note

Docs

@chmouel
Use go_run instead of run_go_tool
9c75e64 
As per the error message whhen running update-codegen.sh

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!!!! WARN: The "run_go_tool" function is deprecated. Use "go_run" instead. !!!!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

run_go_toolthis has been deprecated in favor of go_run, we should use the new
function.
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 4, 2023

@chmouel: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

As per the error message whhen running update-codegen.sh

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! !!!! WARN: The "run_go_tool" function is deprecated. Use "go_run" instead. !!!! !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

run_go_toolthis has been deprecated in favor of go_run, we should use the new function.

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from cardil and krsna-m December 4, 2023 20:24
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 4, 2023

Welcome @chmouel! It looks like this is your first PR to knative-extensions/sample-controller 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 4, 2023

Hi @chmouel. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2023
@dprotaso
Copy link
Contributor

/ok-to-test
/retest

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 10, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e52fb1) 21.31% compared to head (af60075) 21.31%.
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #825   +/-   ##
=======================================
  Coverage   21.31%   21.31%           
=======================================
  Files           9        9           
  Lines          61       61           
=======================================
  Hits           13       13           
  Misses         48       48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor

@cardil have you see this?

Error: stat eval-all: no such file or directory
exit status 1

@dprotaso
Copy link
Contributor

dprotaso commented Jan 9, 2024

/retest

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@dprotaso
Copy link
Contributor

dprotaso commented Jan 9, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, chmouel, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dprotaso
dprotaso reviewed Jan 9, 2024
View reviewed changes
hack/update-codegen.sh
@@ -22,7 +22,7 @@ source $(dirname $0)/../vendor/knative.dev/hack/codegen-library.sh
export PATH="$GOBIN:$PATH"

function run_yq() {
run_go_tool github.com/mikefarah/yq/v4@v4.23.1 yq "$@"
go_run github.com/mikefarah/yq/v4@v4.23.1 "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we had to drop the extra yq argument to the invocation

@knative-prow knative-prow bot merged commit 614cf33 into knative-extensions:main Jan 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@cardil cardil cardil approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@dprotaso dprotaso

@cardil cardil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chmouel @dprotaso @cardil