Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go_run instead of run_go_tool #825

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Use go_run instead of run_go_tool #825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c75e64
Use go_run instead of run_go_tool
chmouel Dec 4, 2023
af60075
drop extra argument
dprotaso Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/update-codegen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ source $(dirname $0)/../vendor/knative.dev/hack/codegen-library.sh
export PATH="$GOBIN:$PATH"

function run_yq() {
run_go_tool github.com/mikefarah/yq/v4@v4.23.1 yq "$@"
go_run github.com/mikefarah/yq/v4@v4.23.1 "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we had to drop the extra yq argument to the invocation

}

echo "=== Update Codegen for ${MODULE_NAME}"
Expand Down
Loading