-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update development documentation #433
Update development documentation #433
Conversation
Welcome @ReToCode! It looks like this is your first PR to knative-sandbox/net-gateway-api 🎉 |
Hi @ReToCode. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 72.76% 72.76%
=======================================
Files 9 9
Lines 683 683
=======================================
Hits 497 497
Misses 157 157
Partials 29 29 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
github action job complains about it. LGTM other than that. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
--skip-teardowns
as it is deprecated (https://github.com/knative/hack/blob/main/e2e-tests.sh#L168).gitignore
to not track downloaded istio folder/kind cleanup
/kind documentation