Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development documentation #433

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

ReToCode
Copy link
Member

Changes

/kind cleanup
/kind documentation

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 13, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 13, 2023

Welcome @ReToCode! It looks like this is your first PR to knative-sandbox/net-gateway-api 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 13, 2023

Hi @ReToCode. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member Author

/cc @nak3 , @dprotaso

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #433 (07e181f) into main (fa956de) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   72.76%   72.76%           
=======================================
  Files           9        9           
  Lines         683      683           
=======================================
  Hits          497      497           
  Misses        157      157           
  Partials       29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nak3
Copy link
Contributor

nak3 commented Jan 13, 2023

github action job complains about it.
https://github.com/knative-sandbox/net-gateway-api/actions/runs/3910487698/jobs/6683808769
Is it possible to fix this?

LGTM other than that.

@nak3
Copy link
Contributor

nak3 commented Jan 16, 2023

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2023
@nak3
Copy link
Contributor

nak3 commented Jan 16, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2023
@knative-prow knative-prow bot merged commit 404d3b1 into knative-extensions:main Jan 16, 2023
@ReToCode ReToCode deleted the fix-development-docs branch January 16, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants