Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Filter out StepStates for implicit steps #338

Closed
imjasonh opened this issue Sep 6, 2018 · 0 comments
Closed

Filter out StepStates for implicit steps #338

imjasonh opened this issue Sep 6, 2018 · 0 comments
Labels
area/api kind/bug Something isn't working kind/good-first-issue Good for newcomers

Comments

@imjasonh
Copy link
Member

imjasonh commented Sep 6, 2018

Expected Behavior

When I run a build that has N steps, I see N StepStates, one for each step I requested.

Actual Behavior

I see N+1 StepStates, or N+2 if my build specified source and had to be fetched.

When populating StepStates, we should filter out the first one, which is the build running creds-init, and if the build specifies source, we should filter out the second one as well.

If we add other implicit steps (e.g., build output collection), we should make sure to filter those out too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api kind/bug Something isn't working kind/good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants