-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐞 Release terminal without races, and accept stdin #170
Conversation
Skipping CI for Draft Pull Request. |
/test unit-tests |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 57.56% 57.56%
=======================================
Files 113 113
Lines 8415 8413 -2
=======================================
- Hits 4844 4843 -1
+ Misses 3307 3306 -1
Partials 264 264 ☔ View full report in Codecov by Sentry. |
/cc @dsimansk |
I've tested this PR on https://github.com/cardil/repro-kn-cli-bad-license with the replace: replace knative.dev/client-pkg => github.com/cardil/knative-client-pkg v0.0.0-20240327105650-518467c4e8c5 and both issues are fixed. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
stdin
without mangle/kind bug
Fixes #168
Fixes #169