Improve "kn service apply" to use a strategic patch strategy for perfoming the 3-way merge #1073
Labels
kind/enhancement
kind/feature
New feature or request
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
triage/accepted
Issues which should be fixed (post-triage)
Feature request
As described in #964 (comment) the way we are performing the 3way merge for a
kn service apply
is limited and can be improved.Use case
Instead of doing a
jsonmergepatch.CreateThreeWayJSONMergePatch
, ideally astrategicpatch.CreateThreeWayMergePatch
should be used but this fails because of lack of support for CRDs like the KnativeService
.Also, an "overwrite" mode should be configurable to allow a forced overwrite in case of a conflict.
It is not clear now, whether the Kubernetes provided utility methods can be used or whether we need to implement our own merge algorithm (based on the knowledge of the supported CRD) instead.
The text was updated successfully, but these errors were encountered: