Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftover fixes for kn service apply #1086

Open
Tracked by #1579
rhuss opened this issue Nov 2, 2020 · 5 comments
Open
Tracked by #1579

Leftover fixes for kn service apply #1086

rhuss opened this issue Nov 2, 2020 · 5 comments
Assignees
@rhuss
Labels
kind/enhancement triage/accepted Issues which should be fixed (post-triage)

Comments

@rhuss
Copy link
Contributor

rhuss commented Nov 2, 2020

The following things should be added to improve #964 :

  • Add Changelog entry
  • Add an e2e test for kn service apply -f
  • Fix some formatting issue (comment after import)
  • Pick the user-container when checking for the container to merge
@rhuss rhuss self-assigned this Nov 2, 2020
@github-actions
Copy link

github-actions bot commented Feb 1, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2021
@dsimansk
Copy link
Contributor

dsimansk commented Feb 1, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2021
@github-actions
Copy link

github-actions bot commented May 3, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2021
@github-actions github-actions bot closed this as completed Jun 2, 2021
@rhuss rhuss reopened this Jun 2, 2021
@github-actions github-actions bot closed this as completed Jul 3, 2021
@rhuss rhuss reopened this Jul 5, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Jul 5, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2021
@rhuss rhuss added kind/enhancement triage/accepted Issues which should be fixed (post-triage) labels Jul 9, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Jan 4, 2022

I think this issue is still relevant and could be handled together with #1073 for improving kn service apply

@rhuss rhuss mentioned this issue Jan 27, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhuss rhuss

Labels
kind/enhancement triage/accepted Issues which should be fixed (post-triage)
Projects
Client Planning
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rhuss @dsimansk @knative-prow-robot