Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ConfigurationEditFlags and create ConfigurationCreateFlags #110

Open
Tracked by #1582
navidshaikh opened this issue May 15, 2019 · 10 comments
Open
Tracked by #1582

Split ConfigurationEditFlags and create ConfigurationCreateFlags #110

navidshaikh opened this issue May 15, 2019 · 10 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/refactor Code refactor needed triage/accepted Issues which should be fixed (post-triage)

Comments

@navidshaikh
Copy link
Collaborator

We have --force option while creating a service, the ConfigurationEditFlags structure can be restructured as suggested here #79 (comment)
@navidshaikh navidshaikh mentioned this issue May 15, 2019
Merged
@sixolet sixolet added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 11, 2019
@navidshaikh
Copy link
Collaborator Author

/assign

@navidshaikh navidshaikh mentioned this issue Aug 10, 2019
Merged
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@steuhs @knative-prow-robot
Run code coverage on the entire knative/pkg repo (knative#110)
45b3a2e 
* added a code coverage job to test running coverage on entire ./

* change the code coverage job to test running coverage on entire ./

* change the code coverage job to test running coverage on entire ./
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2020
@navidshaikh navidshaikh added the kind/refactor Code refactor needed label Nov 17, 2020
@navidshaikh
Copy link
Collaborator Author

/reopen
/remove-lifecycle stale

Added refactor label to it and we can consider this while separating the flags into their own package for re-usability by plugins.

@knative-prow-robot
Copy link
Contributor

@navidshaikh: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle stale

Added refactor label to it and we can consider this while separating the flags into their own package for re-usability by plugins.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2021
@rhuss
Copy link
Contributor

rhuss commented Feb 16, 2021

/remove-lifecycle stale

I think this issue is still valid

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2021
@navidshaikh
Copy link
Collaborator Author

/remove-lifecycle stale
/unassign

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2021
@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Sep 1, 2021
@rhuss
Copy link
Contributor

rhuss commented Sep 1, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 1, 2021
@rhuss rhuss mentioned this issue Jan 27, 2022
Open
4 tasks
dsimansk pushed a commit to dsimansk/client that referenced this issue Jun 29, 2023
@mgencur
Helloworld image running with non root user (knative#110)
09fec4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/refactor Code refactor needed triage/accepted Issues which should be fixed (post-triage)
Projects
Client Planning
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rhuss @sixolet @navidshaikh @knative-prow-robot