-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service create with cpu requests and limits #50
Comments
/milestone v0.1.0 |
@csantanapr: You must be a member of the knative/knative-milestone-maintainers github team to set the milestone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What does this look like? I suggest:
or
Working on this based on above assumption as specified here |
I would turn it around (as in BTW, any reason why memory was not included for this feature request ? |
OK makes sense @rhuss and @navidshaikh. Let me see if I can push something soon. Back at it this week so hopefully no more distractions. Best. |
+1 on supporting units -- having the default units be different than 1 = 1
core seems a little confusing, so I might require units for CPU (or at
least suggest that 75 is a bit wild).
…On Thu, Apr 11, 2019 at 11:50 PM Navid Shaikh ***@***.***> wrote:
I agree with @rhuss <https://github.com/rhuss> for --requests-cpu,
--limits-cpu, --requests-memory and --limits-memory.
Regarding the unit of resources, I think we should support both.
The detailed info on the units can be found here
<https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#resource-requests-and-limits-of-pod-and-container>
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#50 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlyN5SiXvBT87YDfoiI23hzjJaZSwR6ks5vgCzEgaJpZM4cXG8T>
.
--
Evan Anderson <argent@google.com>
|
All, this is addressed in PR #81. I suggest we close unless something is missing. And if what is missing is "small change" to current implementation, just open a separate issue and I will address it. |
Done by #81 |
No description provided.
The text was updated successfully, but these errors were encountered: