Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVELOPMENT.md should describe how to update dependency versions #58

Closed
bbrowning opened this issue Apr 4, 2019 · 2 comments
Closed
Labels
kind/doc Issues and pull requests for documentations

Comments

@bbrowning
Copy link
Contributor

Something like https://github.com/knative/serving/blob/1034bf9b3fc304a944cfccb078198bb26c36ce31/DEVELOPMENT.md#iterating

Especially since we're different from other Knative repos - I was able to figure out, with some internet searching, that to update test-infra in my particular case I needed:

GO111MODULE=on go get -u github.com/knative/test-infra
@bbrowning
Copy link
Contributor Author

And, as it turns out, test-infra is the only thing that is also vendored so I didn't end up updating it properly anyway. I also had to:

GO111MODULE=on go mod vendor

The .gitignore is setup so that anything added to vendor/ other than test-infra stuff gets ignored.

@sixolet sixolet added the kind/doc Issues and pull requests for documentations label Jul 11, 2019
navidshaikh pushed a commit to navidshaikh/client that referenced this issue Aug 13, 2019
🤖 Triggering CI on branch 'release-next' after synching to upstream/master
@rhuss rhuss added this to In progress in Docs Ramp-Up Feb 11, 2020
@rhuss rhuss moved this from In progress to To do in Docs Ramp-Up Feb 11, 2020
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
)

fix the following error:
container has runAsNonRoot and image will run as root: CreateContainerConfigError
@rhuss
Copy link
Contributor

rhuss commented Sep 14, 2020

👍 this explanation should become definitely part of the developer handbook as described in #652 that should be part of this repository. I will update the parent issue with this task and close this one for now.

@rhuss rhuss closed this as completed Sep 14, 2020
Docs Ramp-Up automation moved this from To do to Done Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/doc Issues and pull requests for documentations
Projects
No open projects
Docs Ramp-Up
  
Done
Development

No branches or pull requests

3 participants