Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make command as array instead of string #1380

Merged
merged 6 commits into from Jul 13, 2021

Conversation

itsmurugappan
Copy link
Contributor

Description

make command as string array instead of string

Reference

Fixes #890

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 13, 2021
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsmurugappan: 0 warnings.

In response to this:

Description

make command as string array instead of string

Reference

Fixes #890

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 13, 2021
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1380 (dcaa15a) into main (3860312) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1380   +/-   ##
=======================================
  Coverage   76.48%   76.48%           
=======================================
  Files         160      160           
  Lines        8215     8215           
=======================================
  Hits         6283     6283           
  Misses       1227     1227           
  Partials      705      705           
Impacted Files Coverage Δ
pkg/kn/flags/podspec.go 75.17% <100.00%> (ø)
pkg/kn/flags/podspec_helper.go 74.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3860312...dcaa15a. Read the comment docs.

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2021
CHANGELOG.adoc Outdated Show resolved Hide resolved
@dsimansk
Copy link
Contributor

Just a small nit in a changelog entry, otherwise lgtm. Thanks @itsmurugappan!

@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, itsmurugappan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@knative-prow-robot knative-prow-robot merged commit 0c3e236 into knative:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make 'cmd' an stringArray instead of string
3 participants