Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helloworld image running with non root user #1787

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Mar 17, 2023

Description

Prevents error such as the following when the Pod security context has "runAsNonRoot": true::

"container has runAsNonRoot and image will run as root (pod: \"hello-00001-deployment-65676fb5b5-29mlc_tkn-kn0(930c61ec-28cf-46b8-8dad-d6d54e896b06)\", container: user-container)"

Changes

  • Dockerfile for helloworld runs as USER 65532

Reference

Fixes #

Release Note


@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2023
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@knative-prow
Copy link

knative-prow bot commented Mar 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2023
@knative-prow knative-prow bot merged commit 3e19a35 into knative:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants