-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and reorganise kn cli setup docs #1799
Update and reorganise kn cli setup docs #1799
Conversation
Welcome @garg-dhruv! It looks like this is your first PR to knative/client 🎉 |
Hi @garg-dhruv. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR! Welcome to the Knative community! /ok-to-test |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
- Coverage 79.87% 79.85% -0.03%
==========================================
Files 174 175 +1
Lines 13593 13633 +40
==========================================
+ Hits 10858 10886 +28
- Misses 1992 2000 +8
- Partials 743 747 +4 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Co-authored-by: David Simansky <dsimansk@redhat.com>
/retest |
Co-authored-by: David Simansky <dsimansk@redhat.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, garg-dhruv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Resolves inconsistency in install instructions between docs/README.md and the official website.
Resolution: Point user directly to official website and delete docs/README.md
Also, moving docs/DEVELOPMENT.md to root directory in alignment with other Knative projects.
Reference
Fixes #1410