Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and reorganise kn cli setup docs #1799

Merged
merged 4 commits into from
Apr 12, 2023

Conversation

garg-dhruv
Copy link
Contributor

Description

Resolves inconsistency in install instructions between docs/README.md and the official website.
Resolution: Point user directly to official website and delete docs/README.md

Also, moving docs/DEVELOPMENT.md to root directory in alignment with other Knative projects.

Reference

Fixes #1410

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 2, 2023

Welcome @garg-dhruv! It looks like this is your first PR to knative/client 🎉

@knative-prow
Copy link

knative-prow bot commented Apr 2, 2023

Hi @garg-dhruv. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2023
@garg-dhruv garg-dhruv changed the title [WIP] Update and reorganise kn cli setup docs Update and reorganise kn cli setup docs Apr 4, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@dsimansk
Copy link
Contributor

dsimansk commented Apr 6, 2023

Thanks for the PR! Welcome to the Knative community!

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (3a8d646) 79.87% compared to head (23685e8) 79.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1799      +/-   ##
==========================================
- Coverage   79.87%   79.85%   -0.03%     
==========================================
  Files         174      175       +1     
  Lines       13593    13633      +40     
==========================================
+ Hits        10858    10886      +28     
- Misses       1992     2000       +8     
- Partials      743      747       +4     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

README.md Outdated Show resolved Hide resolved
garg-dhruv and others added 2 commits April 6, 2023 20:17
Co-authored-by: David Simansky <dsimansk@redhat.com>
@dsimansk
Copy link
Contributor

/retest

README.md Outdated Show resolved Hide resolved
Co-authored-by: David Simansky <dsimansk@redhat.com>
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, garg-dhruv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@knative-prow knative-prow bot merged commit 1f9ece2 into knative:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Point installation instructions to docs site?
2 participants