Add 'kn service wait' for deployment status check #1800
Conversation
knative-prow
bot
added
the
do-not-merge/work-in-progress
|
Welcome @manoelmarques! It looks like this is your first PR to knative/client 🎉 |
knative-prow
bot
added
the
needs-ok-to-test
|
Hi @manoelmarques. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@manoelmarques: 1 warning.
In response to this:
Description
Adds a
kn service wait NAME [-n, --namespace string, --wait-timeout int, --wait-window int]Changes
- Add 'kn service wait' for deployment status check
Reference
Fixes #732
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow
bot
added
the
size/L
manoelmarques
force-pushed
the
wait-732
branch
2 times, most recently
from
0f36696
to
49d27bb
Compare
manoelmarques
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
Thanks for the PR! 👍 /ok-to-test |
knative-prow
bot
added
ok-to-test
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
- Coverage 79.87% 79.85% -0.03%
==========================================
Files 174 175 +1
Lines 13593 13633 +40
==========================================
+ Hits 10858 10886 +28
- Misses 1992 2000 +8
- Partials 743 747 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@manoelmarques can you pls rerung |
pkg/kn/commands/service/wait.go
Outdated
| timeoutUsage := "Seconds to wait before giving up on waiting for service to be ready." | ||
| command.Flags().IntVar(&waitFlags.TimeoutInSeconds, "wait-timeout", waitTimeoutDefault, timeoutUsage) | ||
|
|
||
| windowUsage := "Seconds to wait for service to be ready after a false ready condition is returned" | ||
| command.Flags().IntVar(&waitFlags.ErrorWindowInSeconds, "wait-window", 2, windowUsage) |
There was a problem hiding this comment.
Could you pls look at extracting those flags in a separate function in wait_flags.go to be usable without --wati? To keep the names and descriptions if any change happens etc.
https://github.com/knative/client/blob/main/pkg/kn/commands/wait_flags.go#L52-L56
There was a problem hiding this comment.
I changed it by reusing the current function in wait_flags.go
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, manoelmarques The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Description
Adds a
kn service wait NAME [-n, --namespace string, --wait-timeout int, --wait-window int]Changes
Reference
Fixes #732
Release Note