Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core cli dependencies #1851

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Aug 15, 2023

Description

Changes

  • chore: Update core cli dependencies

Reference

Fixes #

Release Note

Update core cli dependencies

/cc @rhuss @vyasgun
/kind cleanup

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 15, 2023
@dsimansk dsimansk requested review from rhuss and vyasgun and removed request for vyasgun August 15, 2023 16:28
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a9ee31f) 79.62% compared to head (93ccbd4) 79.62%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1851   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files         179      179           
  Lines       13927    13927           
=======================================
  Hits        11090    11090           
  Misses       2070     2070           
  Partials      767      767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@dsimansk
Copy link
Contributor Author

/retest

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@rhuss
Copy link
Contributor

rhuss commented Aug 23, 2023

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cb35f6a into knative:main Aug 23, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants