Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck warnings in hack/build.sh script #1860

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix shellcheck warnings in hack/build.sh script #1860

merged 1 commit into from
Sep 5, 2023

Conversation

xiangpingjiang
Copy link
Contributor

@xiangpingjiang xiangpingjiang commented Aug 30, 2023 •
edited by dsimansk

Description

Changes

  • build.sh script

Reference

Fixes #1859

Release Note

Fix shellcheck warnings in `hack/build.sh` script

@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (00f3529) 79.62% compared to head (e897eb4) 79.62%.

❗ Current head e897eb4 differs from pull request most recent head e74af95. Consider uploading reports for the commit e74af95 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1860   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files         179      179           
  Lines       13927    13927           
=======================================
  Hits        11090    11090           
  Misses       2070     2070           
  Partials      767      767

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow
Copy link

knative-prow bot commented Aug 30, 2023

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2023
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 30, 2023
rhuss
rhuss reviewed Aug 30, 2023
View reviewed changes
hack/build.sh Show resolved Hide resolved
@xiangpingjiang
Copy link
Contributor Author

/retest

dsimansk
dsimansk reviewed Sep 1, 2023
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
dsimansk
dsimansk approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding hold for @rhuss to have a look as well. Otherwise it looks good to me. Thanks for accommodating the review feedback promptly!

/lgtm
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2023
@dsimansk dsimansk added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 4, 2023
rhuss
rhuss reviewed Sep 5, 2023
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
rhuss
rhuss reviewed Sep 5, 2023
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
rhuss
rhuss reviewed Sep 5, 2023
View reviewed changes
hack/build.sh Outdated Show resolved Hide resolved
@rhuss
Copy link
Contributor

rhuss commented Sep 5, 2023

Some minor comments, otherwise looks good to me. Thanks @xiangpingjiang !

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xiangpingjiang / name: cola (e74af95)

@xiangpingjiang
Fix shellcheck warnings in hack/build.sh script
e74af95 
Signed-off-by: pingjiang <xiangpingjiang1998@gmail.com>
@xiangpingjiang
Copy link
Contributor Author

/retest

@xiangpingjiang
Copy link
Contributor Author

xiangpingjiang commented Sep 5, 2023 •
edited

@rhuss , Thanks for your reviews, I corrected your comments, could you review my latest code ?

@rhuss
Copy link
Contributor

rhuss commented Sep 5, 2023

Thanks! Looks good to me, thanks a lot for patience :-)

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhuss
Copy link
Contributor

rhuss commented Sep 5, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2023
@knative-prow knative-prow bot merged commit b59e60b into knative:main Sep 5, 2023
18 checks passed
@xiangpingjiang xiangpingjiang deleted the shellcheck branch September 11, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsmurugappan itsmurugappan Awaiting requested review from itsmurugappan

@skonto skonto Awaiting requested review from skonto

@rhuss rhuss Awaiting requested review from rhuss

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@rhuss rhuss

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix shellcheck warnings in hack/build.sh script
3 participants
@xiangpingjiang @dsimansk @rhuss