Corrected version for kn create kafka channel #1886

MeenuyD · 2023-10-28T01:06:13Z

Corrected version for kn create Kafka channel to v1beta1
Fixes #1885

Release Note

Fix version string of Kafka resources in examples

knative-prow · 2023-10-28T01:06:22Z

Welcome @MeenuyD! It looks like this is your first PR to knative/client 🎉

knative-prow · 2023-10-28T01:06:22Z

Hi @MeenuyD. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhuss · 2023-10-31T11:51:10Z

Thanks!

/approve
/lgtm

knative-prow · 2023-10-31T11:51:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MeenuyD, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2023-10-31T11:56:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cef926d) 79.20% compared to head (bcd71e5) 79.20%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1886   +/-   ##
=======================================
  Coverage   79.20%   79.20%           
=======================================
  Files         180      180           
  Lines       14075    14075           
=======================================
  Hits        11148    11148           
  Misses       2155     2155           
  Partials      772      772

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Leo6Leo · 2023-10-31T13:53:50Z

/retest-required

Leo6Leo · 2023-10-31T14:37:05Z

/retest-required

Leo6Leo · 2023-10-31T15:01:21Z

/retest-required

rhuss · 2023-10-31T18:30:28Z

It looks like that the .md file have been updated manually but some has been missed. Please call ./hack/build.sh -c to recreate all doc files

rhuss · 2023-10-31T18:30:56Z

(you can see this also in the logs of the failing test)

dsimansk · 2023-11-01T10:18:45Z

@MeenuyD can you pls run ./hack/build.sh -c? That should produce .md files update in doc/ dir. Thanks!

dsimansk · 2023-11-01T10:20:29Z

/retest

dsimansk · 2023-11-01T10:21:09Z

/ok-to-test

dsimansk · 2023-11-01T10:28:41Z

@MeenuyD can you pls run ./hack/build.sh -c? That should produce .md files update in doc/ dir. Thanks!

Ahh I see, look at sources for channel create and subscription create commands. There's old version reference in the examples as well.

https://github.com/knative/client/blob/main/pkg/kn/commands/channel/create.go#L45

Leo6Leo · 2023-11-01T13:48:35Z

@MeenuyD Also one more minor thing, could you modify the PR description to add the keyword "Fixes #<the issue number that you are trying to fix>"? So that GitHub will automatically link this PR with that issue. When this PR is merged, that issue will be automatically closed too.

FYI, here is the doc for GitHub on how to use the "Fixes" keyword.

rhuss · 2023-11-01T18:55:08Z

pkg/kn/commands/subscription/create.go

@@ -26,7 +26,6 @@ import (
 	"knative.dev/client/pkg/kn/commands"
 	"knative.dev/client/pkg/kn/commands/flags"
 	knflags "knative.dev/client/pkg/kn/flags"
-	knmessagingv1 "knative.dev/client/pkg/messaging/v1"


removing this line seems to break the tests.

Should i remove this line

No, it's used here:

client/pkg/kn/commands/subscription/create.go

Line 73 in a7418fd

sb := knmessagingv1.NewSubscriptionBuilder(name)

Only the example message needs to be changed in the source. Imports should be untouched, i.e. not needed to be changed at all.

dsimansk · 2023-11-30T11:22:09Z

@MeenuyD I've fixed the nit preventing the build to pass. I hope you don't mind.

Thanks for contribution!

/lgtm

knative-prow bot requested review from dsimansk, itsmurugappan and rhuss October 28, 2023 01:06

knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2023

knative-prow bot assigned rhuss Oct 31, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023

knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2023

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2023

rhuss reviewed Nov 1, 2023

View reviewed changes

dsimansk added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 2, 2023

dsimansk removed the request for review from itsmurugappan November 30, 2023 10:08

Corrected version for kn create kafka channel

3f37ecf

MeenuyD and others added 2 commits November 30, 2023 11:12

Correct message

b0e535d

Fix missing import

bcd71e5

knative-prow bot assigned dsimansk Nov 30, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023

knative-prow bot merged commit 5b33d70 into knative:main Nov 30, 2023
23 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Corrected version for kn create kafka channel #1886

Corrected version for kn create kafka channel #1886

MeenuyD commented Oct 28, 2023 •

edited by dsimansk

knative-prow bot commented Oct 28, 2023

knative-prow bot commented Oct 28, 2023

rhuss commented Oct 31, 2023

knative-prow bot commented Oct 31, 2023

codecov bot commented Oct 31, 2023 •

edited

Leo6Leo commented Oct 31, 2023

Leo6Leo commented Oct 31, 2023

Leo6Leo commented Oct 31, 2023

rhuss commented Oct 31, 2023

rhuss commented Oct 31, 2023

dsimansk commented Nov 1, 2023 •

edited

dsimansk commented Nov 1, 2023

dsimansk commented Nov 1, 2023

dsimansk commented Nov 1, 2023 •

edited

Leo6Leo commented Nov 1, 2023 •

edited

rhuss Nov 1, 2023

MeenuyD Nov 2, 2023

dsimansk Nov 2, 2023

dsimansk Nov 2, 2023 •

edited

dsimansk commented Nov 30, 2023

Corrected version for kn create kafka channel #1886

Corrected version for kn create kafka channel #1886

Conversation

MeenuyD commented Oct 28, 2023 • edited by dsimansk

knative-prow bot commented Oct 28, 2023

knative-prow bot commented Oct 28, 2023

rhuss commented Oct 31, 2023

knative-prow bot commented Oct 31, 2023

codecov bot commented Oct 31, 2023 • edited

Codecov Report

Leo6Leo commented Oct 31, 2023

Leo6Leo commented Oct 31, 2023

Leo6Leo commented Oct 31, 2023

rhuss commented Oct 31, 2023

rhuss commented Oct 31, 2023

dsimansk commented Nov 1, 2023 • edited

dsimansk commented Nov 1, 2023

dsimansk commented Nov 1, 2023

dsimansk commented Nov 1, 2023 • edited

Leo6Leo commented Nov 1, 2023 • edited

rhuss Nov 1, 2023

Choose a reason for hiding this comment

MeenuyD Nov 2, 2023

Choose a reason for hiding this comment

dsimansk Nov 2, 2023

Choose a reason for hiding this comment

dsimansk Nov 2, 2023 • edited

Choose a reason for hiding this comment

dsimansk commented Nov 30, 2023

MeenuyD commented Oct 28, 2023 •

edited by dsimansk

codecov bot commented Oct 31, 2023 •

edited

dsimansk commented Nov 1, 2023 •

edited

dsimansk commented Nov 1, 2023 •

edited

Leo6Leo commented Nov 1, 2023 •

edited

dsimansk Nov 2, 2023 •

edited