Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call GetNamespace to get namespace #73

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Call GetNamespace to get namespace #73

merged 1 commit into from
Apr 15, 2019

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Apr 14, 2019

This patch uses GetNamespace() utils in service delete command.

Fixes #72

@nak3
Call GetNamespace to get namespace
8e96078 
This patch uses GetNamespace() utils in service delete command.

Fixes knative#72
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2019
@nak3 nak3 mentioned this pull request Apr 14, 2019
Closed
@nak3
Copy link
Contributor Author

nak3 commented Apr 14, 2019

Would you mind taking a look? @navidshaikh @cppforlife
It looks like 9c21b8d was merged without rebasing on top of 6b2b7f2

@navidshaikh
Copy link
Collaborator

Thanks @nak3 for fixing this!

@cppforlife
Copy link

/ok-to-test
/lgtm
/approve

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, nak3, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service_delete.go 15.4% 18.8% 3.4

@knative-prow-robot knative-prow-robot merged commit 871eaad into knative:master Apr 15, 2019
@nak3 nak3 deleted the fix-panic-delete branch April 16, 2019 00:21
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Apr 24, 2019
@nak3 @rhuss
Call GetNamespace to get namespace (knative#73)
a1a9d1a 
This patch uses GetNamespace() utils in service delete command.

Fixes knative#72
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Remove outdated information in README.md (knative#73)
e651097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidshaikh navidshaikh navidshaikh approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@sixolet sixolet Awaiting requested review from sixolet

Assignees

@cppforlife cppforlife

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go panic from kn service delete command
5 participants
@nak3 @navidshaikh @cppforlife @knative-prow-robot @knative-metrics-robot