Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Cobra generated docs and means to generate them and first cut of other docs #93

Merged
merged 2 commits into from
May 7, 2019

Conversation

maximilien
Copy link
Contributor

@maximilien maximilien commented May 3, 2019

This PR addresses parts of issue #51 with an auto-generated guide as well as a README.md which acts as a user's overview guide.

TODO: add workflow examples and other docs sections.

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2019
@maximilien
Copy link
Contributor Author

/assign @sixolet

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 4, 2019
@maximilien maximilien changed the title Added Cobra generated docs and ways to generate them Adds Cobra generated docs and means to generate them May 4, 2019
@maximilien maximilien force-pushed the docs branch 2 times, most recently from c442be6 to 9d08ac0 Compare May 6, 2019 23:04
@maximilien maximilien changed the title Adds Cobra generated docs and means to generate them Adds Cobra generated docs and means to generate them and first cut of other docs May 6, 2019
@sixolet
Copy link
Contributor

sixolet commented May 7, 2019

/lgtm
/approval

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2019
@sixolet
Copy link
Contributor

sixolet commented May 7, 2019

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2019
@knative-prow-robot knative-prow-robot merged commit 9580827 into knative:master May 7, 2019
dsimansk added a commit to dsimansk/client that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants