Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow test image to be customized #957

Merged
merged 1 commit into from Jul 28, 2020
Merged

allow test image to be customized #957

merged 1 commit into from Jul 28, 2020

Conversation

mvinkler
Copy link
Contributor

Description

Allow the kn test image to be customized via environment variable.

Changes

  • all references to KnDefaultTestImage were replaced with GetKnTestImage() function
  • all hardcoded occuerences of "gcr.io/knative-samples/helloworld-go" were replaced with GetKnTestImage() function

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 28, 2020
knative-prow-robot
knative-prow-robot reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvinkler: 1 warning.

In response to this:

Description

Allow the kn test image to be customized via environment variable.

Changes

  • all references to KnDefaultTestImage were replaced with GetKnTestImage() function
  • all hardcoded occuerences of "gcr.io/knative-samples/helloworld-go" were replaced with GetKnTestImage() function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lib/test/integration.go Show resolved Hide resolved
@knative-prow-robot
Copy link
Contributor

Welcome @mvinkler! It looks like this is your first PR to knative/client 🎉

@knative-prow-robot
Copy link
Contributor

Hi @mvinkler. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2020
@mvinkler mvinkler force-pushed the testimage_from_env branch 2 times, most recently from ff15d95 to 6641b34 Compare July 28, 2020 13:25
@navidshaikh
Copy link
Collaborator

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2020
daisy-ycguo
daisy-ycguo suggested changes Jul 28, 2020
View reviewed changes
test/e2e/service_file_test.go Outdated Show resolved Hide resolved
daisy-ycguo
daisy-ycguo approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@daisy-ycguo daisy-ycguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mvinkler
Copy link
Contributor Author

/assign @navidshaikh

@mvinkler
Copy link
Contributor Author

/retest

@sixolet
Copy link
Contributor

sixolet commented Jul 28, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, mvinkler, sixolet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@sixolet
Copy link
Contributor

sixolet commented Jul 28, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@knative-prow-robot knative-prow-robot merged commit 582e48c into knative:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knative-prow-robot knative-prow-robot knative-prow-robot left review comments

@daisy-ycguo daisy-ycguo daisy-ycguo approved these changes

@maximilien maximilien Awaiting requested review from maximilien

@navidshaikh navidshaikh Awaiting requested review from navidshaikh

Assignees

@sixolet sixolet

@navidshaikh navidshaikh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mvinkler @knative-prow-robot @navidshaikh @sixolet @daisy-ycguo @googlebot