Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create build tests #67

Closed
adrcunha opened this issue Jul 3, 2018 · 1 comment
Closed

Create build tests #67

adrcunha opened this issue Jul 3, 2018 · 1 comment
Assignees
@adrcunha
Labels
kind/infrastructure Docs infrastructure related priority/high

Comments

@adrcunha
Copy link
Contributor

adrcunha commented Jul 3, 2018

"build tests" in this context is not restricted to code, might even include checking markdown file formatting.
@adrcunha adrcunha mentioned this issue Jul 3, 2018
Merged
mchmarny pushed a commit that referenced this issue Jul 3, 2018
@adrcunha @mchmarny
Create presubmit and end-to-end test infrastructure (#68)
5c7ec25 
* Create presubmit and end-to-end test infrastructure

Partially addresses #65.

Note that build, unit and integration tests are currently placeholders for the real stuff (see #67, #66 and #30).

* Fixes:
* Correctly wait for knative/serving to be up
* Add proper E2E header, stating that no tests are run
@rgregg rgregg mentioned this issue Jul 23, 2018
Closed
@RichieEscarez RichieEscarez added kind/infrastructure Docs infrastructure related priority/high labels Aug 14, 2018
@adrcunha adrcunha mentioned this issue Jan 9, 2019
Merged
knative-prow-robot pushed a commit that referenced this issue Jan 10, 2019
@adrcunha @knative-prow-robot
Add real build/unit presubmit tests (#734)
49126fc 
Addresses #66.
Addresses #67.

* Update test-infra to use the default build/unit test runners, which includes building go code and linting markdown files.
* Remove the integration tests, as they only start Knative Serving, which is irrelevant for this repo.

Bonuses:
* fix unbuildable `grpc-ping-go` sample
* remove test-infra import hack from `Gopack.lock` and `update-deps.sh`
@adrcunha
Copy link
Contributor Author

This is done.

adrcunha added a commit that referenced this issue Jan 2, 2020
@adrcunha
Remove outdated TODOs
1ce79c5 
Issues #66 and #67 are now closed.
@adrcunha adrcunha mentioned this issue Jan 2, 2020
Merged
knative-prow-robot pushed a commit that referenced this issue Jan 2, 2020
@adrcunha @knative-prow-robot
Remove outdated TODOs (#2080)
4abb2f9 
Issues #66 and #67 are now closed.
@snyk-bot snyk-bot mentioned this issue Sep 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrcunha adrcunha

Labels
kind/infrastructure Docs infrastructure related priority/high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@labadav @RichieEscarez @adrcunha