Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated TODOs #2080

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Remove outdated TODOs #2080

merged 1 commit into from
Jan 2, 2020

Conversation

adrcunha
Copy link
Contributor

@adrcunha adrcunha commented Jan 2, 2020

Issues #66 and #67 are now closed.

Issues #66 and #67 are now closed.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 2, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2020
@coryrc
Copy link

coryrc commented Jan 2, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2020
@knative-prow-robot knative-prow-robot merged commit 4abb2f9 into master Jan 2, 2020
@RichieEscarez RichieEscarez deleted the adrcunha-patch-1 branch April 21, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants