Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Contributing to sub-dir of knative.dev/community #2086

Merged
merged 2 commits into from
Jan 30, 2020
Merged

Move Contributing to sub-dir of knative.dev/community #2086

merged 2 commits into from
Jan 30, 2020

Conversation

RichieEscarez
Copy link
Contributor

@RichieEscarez RichieEscarez commented Jan 8, 2020 •
edited
Loading

Fixes for #1874

  • Move the existing Contributing directory to a sub-directory of Community: knative.dev/community/contributing
  • Add fully qualified URLs to all links that point to the knative/community repo

Related and dependent changes:

View/test Preview
Staged content for combined PRs (#2086, plus: knative/community#45, knative/website#119)

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RichieEscarez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2020
This was referenced Jan 14, 2020
Merged
Merged
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2020
@RichieEscarez RichieEscarez removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2020
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2020
@RichieEscarez RichieEscarez marked this pull request as ready for review January 14, 2020 06:13
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2020
@RichieEscarez
Copy link
Contributor Author

@samodell this one is also ready, thanks!

@RichieEscarez
Copy link
Contributor Author

Note: The failing ...link-checking errors can be ignored because it is only failing on "example" markdown links (in an example "how to author content" file):

community/contributing/new-page-template.md
	ERROR	../install/README.md
		Stat community/install/README.md: no such file or directory
	ERROR	./page.md
		Stat community/contributing/page.md: no such file or directory

@samodell
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020
@knative-prow-robot knative-prow-robot merged commit 7f3b455 into knative:master Jan 30, 2020
@RichieEscarez RichieEscarez deleted the movecontributing branch March 8, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@gyliu513 gyliu513 Awaiting requested review from gyliu513

Assignees

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RichieEscarez @knative-prow-robot @samodell @googlebot