Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godoc seem seems to go away #2201

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Godoc seem seems to go away #2201

merged 1 commit into from
Feb 11, 2020

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 11, 2020 •
edited
Loading

liinks to godoc seem to be deprecated.

See

Pkg.go.dev is a new destination for Go discovery & docs. Check it out at pkg.go.dev/knative.dev/pkg/apis/duck/v1 and share your feedback.

warning on their site

/assing @mattmoor
/assign @samodell

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 11, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 11, 2020
@matzew matzew changed the title Godoc seem dead 🙀 Godoc seem seems to go away Feb 11, 2020
@lionelvillard
Copy link
Member

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
mattmoor
mattmoor reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, mattmoor, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3061eac into knative:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@lionelvillard lionelvillard lionelvillard approved these changes

@carieshmarie carieshmarie Awaiting requested review from carieshmarie

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@mattmoor mattmoor

@lionelvillard lionelvillard

@samodell samodell

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matzew @lionelvillard @knative-prow-robot @mattmoor @googlebot @samodell