Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the description about Max revision timeout seconds #5884

Merged

Conversation

KAZYPinkSaurus
Copy link
Contributor

This PR is related to knative/serving#14969 .

Because TerminationGracePeriodSeconds is more appropriate than terminationGraceTimeSeconds.
The document probably explain about fallowing value.
https://github.com/knative/serving/blob/6dc7097b740f6b0e6ae744abad5e84338a1b8066/config/core/deployments/activator.yaml#L124

I believe this PR makes this document more understandable.

Thank you.

Proposed Changes

  • Modified terminationGraceTimeSeconds in the document of Max revision timeout seconds to terminationGracePeriodSeconds.

Copy link

linux-foundation-easycla bot commented Mar 3, 2024

CLA Signed

  • ✅login: KAZYPinkSaurus / (cdc3ed9)

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from pmbanugo and skonto March 3, 2024 12:53
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2024
Copy link

knative-prow bot commented Mar 3, 2024

Welcome @KAZYPinkSaurus! It looks like this is your first PR to knative/docs 🎉

Copy link

netlify bot commented Mar 3, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit cdc3ed9
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65e472cd80df450008da6d50
😎 Deploy Preview https://deploy-preview-5884--knative.netlify.app/docs/serving/configuration/config-defaults
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KAZYPinkSaurus KAZYPinkSaurus changed the title Modify the description of ConfigMap config-defaults Modify the description of Max revision timeout seconds Mar 3, 2024
@KAZYPinkSaurus KAZYPinkSaurus changed the title Modify the description of Max revision timeout seconds Modify the description about Max revision timeout seconds Mar 3, 2024
@dprotaso
Copy link
Member

dprotaso commented Mar 3, 2024

/lgtm
/approve
/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2024
Copy link

knative-prow bot commented Mar 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, KAZYPinkSaurus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2024
@knative-prow knative-prow bot merged commit c8356a7 into knative:main Mar 3, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #5885

In response to this:

/lgtm
/approve
/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@KAZYPinkSaurus KAZYPinkSaurus deleted the fix-max-revision-timeout-seconds branch March 4, 2024 12:41
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants