Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test case to test Provisioner/Channel's redelivery feature #1275

Closed
chizhg opened this issue May 24, 2019 · 3 comments
Closed

Add E2E test case to test Provisioner/Channel's redelivery feature #1275

chizhg opened this issue May 24, 2019 · 3 comments
Labels
kind/feature-request wont-fix Bugs or issues that will not be fixed in the next 2-3 releases.

Comments

@chizhg
Copy link
Member

chizhg commented May 24, 2019

Problem
A couple of Provisioner/Channel implementations support redelivery, like GCP PubSub. We need E2E test case to verify this feature.

Exit Criteria
An E2E test case is added to verify the redelivery feature for channels that support it.

@akashrv
Copy link
Contributor

akashrv commented Jun 20, 2019

@Fredy-Z We can ignore the provisioner based channels as they are being deprecated. However, I am assuming the E2E test is needed for the new CRD based channels too. Could you confirm? If so, could you make this part of the existing issues to add e2e test for each channel, or do we need this separate issue?

@chizhg
Copy link
Member Author

chizhg commented Jun 20, 2019

Yes, we'll still need this E2E test.
As I talked with Adam before, for the provisioner based channels, we can have one single E2E test for all provisioners. I'm not sure about CRD based channels, but if we can do the similar thing, we can keep this as a separate issue, and the same for #1274

@paulrossman paulrossman added the wont-fix Bugs or issues that will not be fixed in the next 2-3 releases. label Aug 29, 2019
@paulrossman
Copy link
Contributor

Each channel should have their own E2E tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request wont-fix Bugs or issues that will not be fixed in the next 2-3 releases.
Projects
None yet
Development

No branches or pull requests

3 participants