knative-eventing-injection can't be used with private registry

[duglin]

Describe the bug
While trying to get the e2e tests to work using a private registry, I found that the tests that add the knative-eventing-injection label to a namespace will fail because the pods that get automatically created will fail to be able to pull the needed images. This is because those pods are associated with the eventing-broker-filter ServiceAccount which was also automatically created and there doesn't appear to be a way to inject a pull secret into that service account.

To Reproduce
Run the e2e tests with all images in a private registry.

Knative release version
v0.8.0

/cc @n3wscott

[duglin]

To be clear, I think this is an issue with Eventing itself, not the test infrastructure since this situation will happen during normal usage not just testing.

[grantr]

Good catch. This does seem to be a fundamental issue with the approach, and should at least be documented.

[akashrv]

/assign @duglin

[akashrv]

/milestone v0.10.0

[lionelvillard]

/assign

[lionelvillard]

/unassign
/assign @beemarie

[knative-prow-robot]

@lionelvillard: GitHub didn't allow me to assign the following users: beemarie.

Note that only knative members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/unassign
/assign @beemarie

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bvennam]

@lionelvillard It looks like if I comment, I should be able to be assigned?

[lionelvillard]

/assign @beemarie

[lionelvillard]

/milestone v0.12.0

[knative-prow-robot]

@lionelvillard: You must be a member of the knative/knative-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v0.12.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.