Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to class based broker controller #2840

Closed
liu-cong opened this issue Mar 25, 2020 · 0 comments · Fixed by #2910
Closed

Upgrade to class based broker controller #2840

liu-cong opened this issue Mar 25, 2020 · 0 comments · Fixed by #2910
Labels
area/eventing The Eventing api group kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@liu-cong
Copy link
Contributor

liu-cong commented Mar 25, 2020

Describe the bug
The broker controller now only reconciles brokers with ChannelBasedBroker annotation. And we have defaulting and conversion webhooks to set the default broker class.

However, for brokers created before the new controller/webhooks, our new controller will ignore them because they don't have the annotation. If you do kubectl get, you will still see the annotation set by the conversion webhook. However, this annotation is not persisted for brokers created before the new webhooks.

Expected behavior
Previously created brokers should get reconciled after upgrading to the new broker controller.

To Reproduce

  • Install a previous release of eventing, create a broker, verify that the broker doesn't have the brokerclass annotation.
  • Install broker controller and webhooks from master
  • Create a trigger to the previously created broker, and the broker is not reconciled.

Additional context
I can think of the following options:

  1. Ask the user to manually modify the brokers so the defaulting webhook will add the annotation. Bad UX.
  2. Have an upgrade job to list all brokers without brokerclass and set the default broker class.
  3. Have the broker controller reconcile brokers with no brokerclass annotation, POC here Allow default broker controller to reconcile unset brokerclass. #2761
@liu-cong liu-cong added the kind/bug Categorizes issue or PR as related to a bug. label Mar 25, 2020
@grantr grantr added area/eventing The Eventing api group priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 30, 2020
@grantr grantr added this to the v0.14.0 milestone Mar 30, 2020
@grantr grantr assigned liu-cong and unassigned liu-cong Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing The Eventing api group kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants