-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade script for patching broker annotation #2910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
/cc @liu-cong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
config/upgrade/v0.14.0/README.md
Outdated
If you installed to different namespace, you need to modify the upgrade.yaml | ||
appropriately. Also the job by default runs as `eventing-controller` service | ||
account, you can also modify that but the service account will need to have | ||
permissions to list `Namespace`s, list and patch `Broker`s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format markdown:
permissions to list `Namespace`s, list and patch `Broker`s. | |
permissions to list `Namespace`s, list and patch `Broker`s. |
annotation like so. | ||
|
||
``` | ||
annotations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be removed after the release ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits plus a couple of places where errors need to be handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure when this should be removed, but since it's versioned I don't think it's required to remove it.
Thank you for writing such comprehensive unit tests! 😍
/lgtm
/hold
Holding for other comments, but I'd like to get this in by pre-release cutoff (tomorrow) so we can all start testing it.
@vaikas do we need a docs PR too? Since the install docs link directly to release artifacts, anyone following the install instructions to upgrade won't see that this is required. To be fair that seems like a general docs problem and not specific to this issue. |
I don't see a need to remove it after the release, that's why I versioned it. But thoughts? |
@liu-cong thanks, I believe I addressed all comments, PTAL. @grantr Seems like we should have a separate "upgrade" section and I don't see a place for it, seems like in the past the ReleaseNotes has been a place where we've tacked things that require attention and from what I understand that's been working? |
The following is the coverage report on the affected files.
|
/hold cancel
Agreed. I'll open an issue in docs.
I don't know if it's working or not, but I guess we haven't had many complaints. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes #2840
Proposed Changes
Release Note
Docs