Upgrade script for patching broker annotation

[vaikas]

Fixes #2840

Proposed Changes

• Introduce a script that runs as a job that will patch all Brokers without BrokerClass annotation to ChannelBasedBroker

Release Note

- 🐛 Fix bug
* action required * You have to run the provided upgrade script, or something like this to update all the Brokers with the proper BrokerClass or they will not continue to be reconciled after 0.14 cuts.
Details for the script are in:
config/upgrade/v0.14.0/README.md
Release artifact is:
https://github.com/knative/eventing/releases

Docs

[mattmoor]

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

[mattmoor]

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

[grantr]

/cc @liu-cong

[mattmoor]

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

[mattmoor]

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

[mattmoor]

Format markdown:

Suggested change

	permissions to list `Namespace`s, list and patch `Broker`s.
	permissions to list `Namespace`s, list and patch `Broker`s.

[matzew]

@k4leung4 I think this is someting that the operator should do
/cc @aliok

[matzew]

will this be removed after the release ?

[liu-cong]

a few nits plus a couple of places where errors need to be handled.

[grantr]

I'm not sure when this should be removed, but since it's versioned I don't think it's required to remove it.

Thank you for writing such comprehensive unit tests! 😍

/lgtm
/hold
Holding for other comments, but I'd like to get this in by pre-release cutoff (tomorrow) so we can all start testing it.

[grantr]

@vaikas do we need a docs PR too? Since the install docs link directly to release artifacts, anyone following the install instructions to upgrade won't see that this is required. To be fair that seems like a general docs problem and not specific to this issue.

[vaikas]

I don't see a need to remove it after the release, that's why I versioned it. But thoughts?

[vaikas]

@liu-cong thanks, I believe I addressed all comments, PTAL.

@grantr Seems like we should have a separate "upgrade" section and I don't see a place for it, seems like in the past the ReleaseNotes has been a place where we've tacked things that require attention and from what I understand that's been working?

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/upgrader/broker/v0.14.0/upgrader.go	Do not exist	77.4%

[grantr]

/hold cancel

Seems like we should have a separate "upgrade" section

Agreed. I'll open an issue in docs.

from what I understand that's been working?

I don't know if it's working or not, but I guess we haven't had many complaints. 😃

[grantr]

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grantr,vaikas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[liu-cong]

/lgtm