Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace scoped channel doesn't work #4754

Closed
pierDipi opened this issue Jan 18, 2021 · 4 comments
Closed

Namespace scoped channel doesn't work #4754

pierDipi opened this issue Jan 18, 2021 · 4 comments
Labels
area/channels area/security kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@pierDipi
Copy link
Member

Describe the bug

Reconciling dispatcher RoleBinding failed: rolebindings.rbac.authorization.k8s.io \"imc-dispatcher\" is forbidden: user \"system:serviceaccount:knative-eventing:imc-controller\" (groups=[\"system:serviceaccounts\" \"system:serviceaccounts:knative-eventing\" \"system:authenticated\"]) is attempting to grant RBAC permissions not currently held:\n{APIGroups:[\"messaging.knative.dev\"], Resources:[\"inmemorychannels\"], Verbs:[\"patch\"]}\n{APIGroups:[\"messaging.knative.dev\"], Resources:[\"inmemorychannels/finalizers\"], Verbs:[\"patch\"]}\n{APIGroups:[\"messaging.knative.dev\"], Resources:[\"inmemorychannels/status\"], Verbs:[\"patch\"]}"

Expected behavior

It works.

To Reproduce

  1. Apply:
apiVersion: messaging.knative.dev/v1
kind: InMemoryChannel
metadata:
  name: imc
  annotations:
    eventing.knative.dev/scope: namespace
  1. Send events to it

Knative release version
>= 0.17

Additional context

@vaikas
Copy link
Contributor

vaikas commented Jan 19, 2021

Hrm. We used to have finalizers on the IMC, but no longer require them, is this some left over cruft from that era?

@lberk lberk added kind/good-first-issue Denotes an issue ready for a new contributor. area/security area/channels priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jan 25, 2021
@lberk lberk added this to the v0.21.0 milestone Jan 25, 2021
@grantr
Copy link
Contributor

grantr commented Mar 8, 2021

This issue is still in v0.21.0. Should we move it to a future release milestone or to the backlog?

Also is it still critical-urgent if it's been unchanged for over a month? @pierDipi

@pierDipi
Copy link
Member Author

pierDipi commented Mar 8, 2021

It seems this was fixed by @lionelvillard in #4906.

/close

@knative-prow-robot
Copy link
Contributor

@pierDipi: Closing this issue.

In response to this:

It seems this was fixed by @lionelvillard in #4906.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/channels area/security kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

5 participants