Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Conformance] Broker spec.config is not immutable as described in the spec #5663

Closed
salaboy opened this issue Aug 25, 2021 · 0 comments · Fixed by #5682
Closed

[Conformance] Broker spec.config is not immutable as described in the spec #5663

salaboy opened this issue Aug 25, 2021 · 0 comments · Fixed by #5682
Assignees
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@salaboy
Copy link
Member

salaboy commented Aug 25, 2021

Describe the bug
You can patch a broker spec.config field and you shouldn't be able to do that as it should be immutable as described here:
https://github.com/knative/specs/blob/main/specs/eventing/control-plane.md#broker-lifecycle

Expected behavior
You should get an error when you try to patch the spec.config of a broker.

To Reproduce

  1. Create a Broker (my-broker)
  2. Run: kubectl patch broker my-broker --type merge -p '{"spec":{"config":{"apiVersion":"v1"}}}'

Knative release version

v0.24.1

Additional context
The reference implementation should conform to the spec.

@salaboy salaboy added the kind/bug Categorizes issue or PR as related to a bug. label Aug 25, 2021
@lionelvillard lionelvillard added this to the v0.26.0 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants