Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Event Filtering: Add rekt test for multiple triggers & sinks #7241

Closed
Cali0707 opened this issue Sep 7, 2023 · 4 comments · Fixed by #7350
Closed

New Event Filtering: Add rekt test for multiple triggers & sinks #7241

Cali0707 opened this issue Sep 7, 2023 · 4 comments · Fixed by #7350
Assignees
@Cali0707
Labels
area/test-and-release Test infrastructure, tests or release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Cali0707 commented Sep 7, 2023

Problem
Current rekt tests for the new event filters are testing multiple filters on a single trigger with a single sink. We should verify that the new event filters implementation correctly sends events to different sinks when there is more than one trigger.

Persona:
Which persona is this feature for?

Exit Criteria
A test with 2 triggers and 2 sinks that verifies that:

  • An event matching filters for the first trigger delivers to the first sink, but not the second
  • An event matching filters for the second trigger delivers to the second sink, but not the first
  • An event matching filters for both triggers delivers to both sinks
  • An event matching neither filter delivers to none of the sinks

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.
@Cali0707
Copy link
Member Author

Cali0707 commented Sep 7, 2023

/area test-and-release

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label Sep 7, 2023
@Cali0707 Cali0707 mentioned this issue Sep 7, 2023
Closed
@Cali0707
Copy link
Member Author

/help

@knative-prow
Copy link

knative-prow bot commented Sep 12, 2023

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 12, 2023
@pierDipi pierDipi added the triage/accepted Issues which should be fixed (post-triage) label Sep 21, 2023
@Cali0707
Copy link
Member Author

/assign

@Cali0707 Cali0707 mentioned this issue Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cali0707 Cali0707

Labels
area/test-and-release Test infrastructure, tests or release help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
New Event Filtering
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added test for multiple sinks, multiple triggers Cali0707/eventing
2 participants
@pierDipi @Cali0707