Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase expiration buffer time of OIDCTokenProviders cache #7351

Closed
creydr opened this issue Oct 12, 2023 · 1 comment · Fixed by #7355
Closed

Increase expiration buffer time of OIDCTokenProviders cache #7351

creydr opened this issue Oct 12, 2023 · 1 comment · Fixed by #7355
Assignees
@akagami-harsh
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@creydr
Copy link
Member

creydr commented Oct 12, 2023

Currently the cache of the OIDC token provider has only a buffer of 30 seconds:

eventing/pkg/auth/token_provider.go

Lines 34 to 36 in da0fba3

const (
expirationBufferTime = time.Second * 30
)

To take also clock screw into account, we should increase this limit to 5 minutes.
@creydr creydr added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 12, 2023
@creydr creydr mentioned this issue Oct 12, 2023
Merged
5 tasks
@akagami-harsh
Copy link
Contributor

/assign

akagami-harsh added a commit to akagami-harsh/eventing that referenced this issue Oct 12, 2023
@akagami-harsh
Fix: Issue knative#7351 Increasing expiration buffer time of OIDCToke…
b59c9d3 
…nProviders cache to 5 minuets

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@akagami-harsh akagami-harsh mentioned this issue Oct 12, 2023
Merged
5 tasks
knative-prow bot pushed a commit that referenced this issue Oct 18, 2023
@akagami-harsh @pierDipi
Increase expiration buffer time of OIDCTokenProviders cache to 5 minu…
3ef831c 
…tes (#7355)

* Fix: Issue #7351 Increasing expiration buffer time of OIDCTokenProviders cache to 5 minuets

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>

* Update pkg/auth/token_provider.go

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

* updating comment on line no 76

---------

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akagami-harsh akagami-harsh

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
Eventing Sender Identity
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes akagami-harsh/eventing
2 participants
@creydr @akagami-harsh