Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TLS for OIDC e2e tests #7496

Closed
mgencur opened this issue Dec 6, 2023 · 3 comments · Fixed by #7551
Closed

Enable TLS for OIDC e2e tests #7496

mgencur opened this issue Dec 6, 2023 · 3 comments · Fixed by #7551
Assignees
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@mgencur
Copy link
Contributor

mgencur commented Dec 6, 2023

The E2E tests under test/auth verify OIDC authentication but don't enable TLS.
The OIDC features is mostly useful when TLS is enabled for communication between components.

TLS can be enabled for reconciler-test through WithTLS option:

ctx, env := global.Environment(
  ..
  eventshub.WithTLS(t)
  ...
)

The tests will need to be modified to properly start EventsHub receiver/sender with enforced TLS and individual resources which deliver events will have to specify CACerts for Destination:

d := service.AsDestinationRef(sink)
d.CACerts = eventshub.GetCaCerts(ctx)
@Cali0707
Copy link
Member

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Dec 18, 2023
@Leo6Leo
Copy link
Member

Leo6Leo commented Jan 5, 2024

/assign
This Issue will be ready to work on after #7320 is completed

@creydr
Copy link
Member

creydr commented Jan 8, 2024

@Leo6Leo thanks for taking this.
You can also split this into multiple PRs (e.g. my migrating the tests for apiserversource, broker, channel, containersource, ... separately), so you don't have to wait for #7320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

4 participants