Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TLS for PingSource's OIDC tests #7549

Closed
Leo6Leo opened this issue Jan 8, 2024 · 1 comment · Fixed by #7551
Closed

Enable TLS for PingSource's OIDC tests #7549

Leo6Leo opened this issue Jan 8, 2024 · 1 comment · Fixed by #7551
Assignees

Comments

@Leo6Leo
Copy link
Member

Leo6Leo commented Jan 8, 2024

This is a sub-issue for issue #7496, and depend on #7320

The E2E tests for PingSource under test/auth verify OIDC authentication but don't enable TLS.

The OIDC features is mostly useful when TLS is enabled for communication between components.

TLS can be enabled for reconciler-test through WithTLS option:

ctx, env := global.Environment(
  ..
  eventshub.WithTLS(t)
  ...
)

The tests will need to be modified to properly start EventsHub receiver/sender with enforced TLS and individual resources which deliver events will have to specify CACerts for Destination:

d := service.AsDestinationRef(sink)
d.CACerts = eventshub.GetCaCerts(ctx)

Exit Criteria
EventsHub receiver/sender with enforced TLS and individual resources which deliver events with CACerts specified for Destination

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.

@Leo6Leo Leo6Leo converted this from a draft issue Jan 8, 2024
@sadath-12
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants