Update knative/pkg dependency. #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/lgtm |
chizhg
pushed a commit
to chizhg/eventing
that referenced
this pull request
May 13, 2019
* Update knative/pkg dependency. * hack/update-codegen.sh
slinkydeveloper
pushed a commit
to slinkydeveloper/eventing
that referenced
this pull request
Apr 19, 2021
…e#1191) knative.dev/pkg controller runtime doesn't allow for global level resync and leaderelection functions to filter out objects set by filter funcs. In the case of the crd controller -- this means our reconciliation process picks up unrelated objets to try and create duck controllers. Add an extra check in the reconcile process equivalent to the informer filterFunc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #704.
Proposed Changes
Release Note