Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing support to in-memory dispatcher. #1199

Merged
merged 3 commits into from May 9, 2019
Merged

Add tracing support to in-memory dispatcher. #1199

merged 3 commits into from May 9, 2019

Conversation

Harwayne
Copy link
Contributor

@Harwayne Harwayne commented May 9, 2019 •
edited

Helps with #704

Proposed Changes

  • Add Zipkin tracing support to the in-memory Channel dispatcher.

Release Note

New permissions have been granted to the `in-memory-channel-dispatcher` ServiceAccount, you will need to apply them or the Deployment will crash loop.
A new ConfigMap has been added `config-tracing` to `knative-eventing`. It must be deployed or the dispatcher Deployment will crash loop.

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 9, 2019
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 9, 2019
mattmoor-sockpuppet
mattmoor-sockpuppet reviewed May 9, 2019
View reviewed changes
third_party/VENDOR-LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2017 The OpenZipkin Authors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor The sockpuppet is trying to change a vendor's copied license.

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2019
Harwayne
Harwayne commented May 9, 2019
View reviewed changes
third_party/VENDOR-LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2017 The OpenZipkin Authors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor The sockpuppet is trying to change a vendor's copied license.

mattmoor-sockpuppet
mattmoor-sockpuppet reviewed May 9, 2019
View reviewed changes
third_party/VENDOR-LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2017 The OpenZipkin Authors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor The sockpuppet is trying to change a vendor's copied license.

Harwayne
Harwayne commented May 9, 2019
View reviewed changes
third_party/VENDOR-LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2017 The OpenZipkin Authors
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor The sockpuppet is trying to change a vendor's copied license.

@Harwayne Harwayne marked this pull request as ready for review May 9, 2019 18:59
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2019
Harwayne
Harwayne commented May 9, 2019
View reviewed changes
pkg/tracing/setup.go
"go.uber.org/zap"
)

// TODO Move this to knative/pkg.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdemirhan I'm intending to move this up to knative/pkg once I prove it is useful in eventing. Would you mind reviewing this file?

mattmoor-sockpuppet
mattmoor-sockpuppet reviewed May 9, 2019
View reviewed changes
third_party/VENDOR-LICENSE
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2017 The OpenZipkin Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2017 The OpenZipkin Authors
Copyright 2019 The OpenZipkin Authors

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/provisioners/message_receiver.go 79.4% 74.3% -5.1

grantr
grantr approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 64df1c3 into knative:master May 9, 2019
@Harwayne Harwayne deleted the in-memory-tracing branch May 9, 2019 22:09
chizhg pushed a commit to chizhg/eventing that referenced this pull request May 13, 2019
@Harwayne @chizhg
Add tracing support to in-memory dispatcher. (knative#1199)
86642e1 
* Add tracing support to in-memory dispatcher.

* Remove ClusterRole configmaps.
@matzew matzew mentioned this pull request Jun 4, 2019
Closed
@Harwayne Harwayne mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor-sockpuppet mattmoor-sockpuppet mattmoor-sockpuppet left review comments

@grantr grantr grantr approved these changes

@matzew matzew Awaiting requested review from matzew

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@grantr grantr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Harwayne @knative-metrics-robot @knative-prow-robot @grantr @mattmoor-sockpuppet @googlebot