-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default Tracing Config #1294
Fix default Tracing Config #1294
Conversation
The following is the coverage report on pkg/.
|
38279ba
to
51c70c5
Compare
RFAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grantr, Harwayne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-eventing-unit-tests |
/test pull-knative-eventing-integration-tests |
1 similar comment
/test pull-knative-eventing-integration-tests |
* Rollback certificate algorithm changes (knative#1281) * Allow URIs to be resolved without reconciler context (knative#2095) (knative#1274) Co-authored-by: Mona Borham <mionaut@gmail.com> * fix oom (knative#1266) * silent noisy metrics (knative#1223) Co-authored-by: Markus Thömmes <markusthoemmes@me.com> Co-authored-by: Lukas Berk <lberk@redhat.com> Co-authored-by: Mona Borham <mionaut@gmail.com> Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
This is based on #1290 and will be WIP until that PR is merged.
Proposed Changes
Release Note