Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default Tracing Config #1294

Merged

Conversation

Harwayne
Copy link
Contributor

This is based on #1290 and will be WIP until that PR is merged.


Proposed Changes

  • Use the default tracing ConfigMap, if the real ConfigMap does not exist.

Release Note

NONE

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2019
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 29, 2019
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2019
@Harwayne Harwayne mentioned this pull request May 29, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/broker/broker.go Do not exist 87.6%

@Harwayne Harwayne force-pushed the working-default-config-map branch from 38279ba to 51c70c5 Compare June 4, 2019 20:14
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2019
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2019
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2019
@Harwayne Harwayne changed the title [WIP] Fix default Tracing Config Fix default Tracing Config Jun 5, 2019
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2019
@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 5, 2019

RFAL

Copy link
Contributor

@grantr grantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grantr, Harwayne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 5, 2019

/test pull-knative-eventing-unit-tests

@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 5, 2019

/test pull-knative-eventing-integration-tests

1 similar comment
@Harwayne
Copy link
Contributor Author

Harwayne commented Jun 6, 2019

/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit c52f8d6 into knative:master Jun 6, 2019
@Harwayne Harwayne deleted the working-default-config-map branch June 6, 2019 17:36
mgencur pushed a commit to openshift-knative/eventing that referenced this pull request Nov 14, 2022
* Rollback certificate algorithm changes (knative#1281)

* Allow URIs to be resolved without reconciler context (knative#2095) (knative#1274)

Co-authored-by: Mona Borham <mionaut@gmail.com>

* fix oom (knative#1266)

* silent noisy metrics (knative#1223)

Co-authored-by: Markus Thömmes <markusthoemmes@me.com>
Co-authored-by: Lukas Berk <lberk@redhat.com>
Co-authored-by: Mona Borham <mionaut@gmail.com>
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants